https://bugzilla.redhat.com/show_bug.cgi?id=2481782

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Jitka Plesnikova <[email protected]> ---
> License
> FIX: The license should be Artistic-2.0. It is mention in README
@@ -4,3 +4,3 @@
 Summary:        Convert between vCard and JSContact
-License:        GPL-1.0-or-later OR Artistic-1.0-Perl
+License:        Artistic-2.0
 URL:            https://metacpan.org/dist/Text-JSContact
Ok

> BuildRequires
> FIX: Please add build-requires
>      perl(Exporter) - lib/Text/JSContact.pm:19
>      perl(HTTP::Request) - t/cyrus-carddav.t:8
>      perl(lib) - t/basic.t:8
@@ -18,2 +18,3 @@
 BuildRequires:  perl(Encode)
+BuildRequires:  perl(Exporter)
 BuildRequires:  perl(JSON)
@@ -23,4 +24,6 @@
 # Tests:
-BuildRequires:  perl(LWP::UserAgent)
+BuildRequires:  perl(HTTP::Request)
 BuildRequires:  perl(JSON::XS)
+BuildRequires:  perl(lib)
+BuildRequires:  perl(LWP::UserAgent)
 BuildRequires:  perl(Test::More)
Ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2481782

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202481782%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to