https://bugzilla.redhat.com/show_bug.cgi?id=2467501
Benson Muite <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #10 from Benson Muite <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License". 9 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/libwignernj/2467501- libwignernj/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.14, /usr/lib64/python3.14/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 27840 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-wignernj [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libwignernj-0.6.0-1.fc45.x86_64.rpm libwignernj-devel-0.6.0-1.fc45.x86_64.rpm libwignernj-fortran-0.6.0-1.fc45.x86_64.rpm python3-wignernj-0.6.0-1.fc45.x86_64.rpm libwignernj-doc-0.6.0-1.fc45.noarch.rpm libwignernj-0.6.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp80r4fek6')] checks: 32, packages: 6 libwignernj.src: E: spelling-error ('representable', '%description -l en_US representable -> re presentable, re-presentable, represent able') libwignernj.src: E: spelling-error ('libquadmath', '%description -l en_US libquadmath -> quadruplicate') libwignernj.src: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so') libwignernj.x86_64: E: spelling-error ('representable', '%description -l en_US representable -> re presentable, re-presentable, represent able') libwignernj.x86_64: E: spelling-error ('libquadmath', '%description -l en_US libquadmath -> quadruplicate') libwignernj.x86_64: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so') libwignernj-devel.x86_64: E: spelling-error ('hpp', '%description -l en_US hpp -> hop, hp, pp') libwignernj-devel.x86_64: E: spelling-error ('mpfr', '%description -l en_US mpfr -> mfr, mp fr, mp-fr') libwignernj-devel.x86_64: E: spelling-error ('libquadmath', '%description -l en_US libquadmath -> quadruplicate') libwignernj-devel.x86_64: E: spelling-error ('quadmath', '%description -l en_US quadmath -> quad math, quad-math, quadratic') libwignernj-fortran.x86_64: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so') libwignernj-fortran.x86_64: E: spelling-error ('wcg', '%description -l en_US wcg -> cg, wig, wag') libwignernj-fortran.x86_64: E: spelling-error ('wracahw', '%description -l en_US wracahw -> wrack') libwignernj-fortran.x86_64: E: spelling-error ('wfanox', '%description -l en_US wfanox -> snowfall') libwignernj-fortran.x86_64: E: spelling-error ('wgaunt', '%description -l en_US wgaunt -> gaunt, w gaunt') libwignernj-fortran.x86_64: E: spelling-error ('libquadmath', '%description -l en_US libquadmath -> quadruplicate') libwignernj-fortran.x86_64: E: spelling-error ('precisions', "%description -l en_US precisions -> previsions, precision, precision's") python3-wignernj.x86_64: E: spelling-error ('libwignernj', 'Summary(en_US) libwignernj -> libertine') python3-wignernj.x86_64: E: spelling-error ('libwignernj', '%description -l en_US libwignernj -> libertine') python3-wignernj.x86_64: E: spelling-error ('longdouble', '%description -l en_US longdouble -> long double, long-double, doubloon') libwignernj.spec:104: W: macro-in-comment %install 6 packages and 0 specfiles checked; 20 errors, 1 warnings, 42 filtered, 20 badness; has taken 1.3 s Rpmlint (debuginfo) ------------------- Checking: libwignernj-debuginfo-0.6.0-1.fc45.x86_64.rpm libwignernj-fortran-debuginfo-0.6.0-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp45vkzyt1')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 14 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyFloat_Type (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyExc_ValueError (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyExc_TypeError (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so _Py_NoneStruct (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyList_New (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyArg_ParseTupleAndKeywords (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyMem_Free (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyObject_GetAttrString (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so _Py_Dealloc (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyErr_NoMemory (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyErr_SetString (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyFloat_FromDouble (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyErr_Occurred (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyModule_Create2 (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyLong_AsLong (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyFloat_AsDouble (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyUnicode_AsUTF8 (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyType_IsSubtype (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyComplex_FromDoubles (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyErr_Format (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) python3-wignernj.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so PyMem_Malloc (/usr/lib64/python3.14/site-packages/wignernj/_wignernj.so) libwignernj.x86_64: E: spelling-error ('representable', '%description -l en_US representable -> re presentable, re-presentable, represent able') libwignernj.x86_64: E: spelling-error ('libquadmath', '%description -l en_US libquadmath -> quadrillionth') libwignernj.x86_64: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so') libwignernj-devel.x86_64: E: spelling-error ('hpp', '%description -l en_US hpp -> hop, hp, pp') libwignernj-devel.x86_64: E: spelling-error ('mpfr', '%description -l en_US mpfr -> mfr, mp fr, mp-fr') libwignernj-devel.x86_64: E: spelling-error ('libquadmath', '%description -l en_US libquadmath -> quadrillionth') libwignernj-devel.x86_64: E: spelling-error ('quadmath', '%description -l en_US quadmath -> quad math, quad-math, quadratic') libwignernj-fortran.x86_64: E: spelling-error ('iso', '%description -l en_US iso -> ISO, is, so') libwignernj-fortran.x86_64: E: spelling-error ('wcg', '%description -l en_US wcg -> cg, wig, wag') libwignernj-fortran.x86_64: E: spelling-error ('wracahw', '%description -l en_US wracahw -> wrack') libwignernj-fortran.x86_64: E: spelling-error ('wfanox', '%description -l en_US wfanox -> snowfall') libwignernj-fortran.x86_64: E: spelling-error ('wgaunt', '%description -l en_US wgaunt -> gaunt, w gaunt') libwignernj-fortran.x86_64: E: spelling-error ('libquadmath', '%description -l en_US libquadmath -> quadrillionth') libwignernj-fortran.x86_64: E: spelling-error ('precisions', '%description -l en_US precisions -> previsions, precision, precis ions') python3-wignernj.x86_64: E: spelling-error ('libwignernj', 'Summary(en_US) libwignernj -> libertine') python3-wignernj.x86_64: E: spelling-error ('libwignernj', '%description -l en_US libwignernj -> libertine') python3-wignernj.x86_64: E: spelling-error ('longdouble', '%description -l en_US longdouble -> long double, long-double, doubloon') 7 packages and 0 specfiles checked; 17 errors, 21 warnings, 54 filtered, 17 badness; has taken 1.5 s Unversioned so-files -------------------- python3-wignernj: /usr/lib64/python3.14/site-packages/wignernj/_wignernj.so Source checksums ---------------- https://github.com/susilehtola/libwignernj/archive/v0.6.0/libwignernj-0.6.0.tar.gz : CHECKSUM(SHA256) this package : bceaca2cfb50b3b7ea15e889c152c174b23f3eed384901897f5c245229142aaf CHECKSUM(SHA256) upstream package : bceaca2cfb50b3b7ea15e889c152c174b23f3eed384901897f5c245229142aaf Requires -------- libwignernj (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) libmpfr.so.6()(64bit) libquadmath.so.0()(64bit) libquadmath.so.0(QUADMATH_1.0)(64bit) rtld(GNU_HASH) libwignernj-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) libquadmath-devel(x86-64) libstdc++-devel(x86-64) libwignernj(x86-64) libwignernj.so.0()(64bit) libwignernj_f03.so.0()(64bit) mpfr-devel(x86-64) pkgconfig(libwignernj) libwignernj-fortran (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_4.3.0)(64bit) libgfortran.so.5()(64bit) libgfortran.so.5(GFORTRAN_8)(64bit) libm.so.6()(64bit) libwignernj(x86-64) libwignernj.so.0()(64bit) rtld(GNU_HASH) python3-wignernj (rpmlib, GLIBC filtered): libc.so.6()(64bit) libwignernj.so.0()(64bit) python(abi) rtld(GNU_HASH) libwignernj-doc (rpmlib, GLIBC filtered): Provides -------- libwignernj: libwignernj libwignernj(x86-64) libwignernj.so.0()(64bit) libwignernj-devel: cmake(wignernj) libwignernj-devel libwignernj-devel(x86-64) pkgconfig(libwignernj) pkgconfig(libwignernj_f03) libwignernj-fortran: libwignernj-fortran libwignernj-fortran(x86-64) libwignernj_f03.so.0()(64bit) python3-wignernj: python-wignernj python3-wignernj python3-wignernj(x86-64) python3.14-wignernj python3.14dist(wignernj) python3dist(wignernj) libwignernj-doc: libwignernj-doc Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2467501 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic, C/C++ Disabled plugins: Ocaml, PHP, Haskell, SugarActivity, fonts, Perl, R, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: 1) To get the module files installed, please change: mkdir -p %{buildroot}%{fmoddir} mv %{buildroot}%{_includedir}/wignernj/fortran/*.mod %{buildroot}%{fmoddir}/ to mkdir -p %{buildroot}%{_fmoddir} mv %{buildroot}%{_includedir}/wignernj/fortran/*.mod %{buildroot}%{_fmoddir}/ In the devel package, please add: %{_fmoddir}/wignernj.mod 2) Please also make the devel package require gcc-gfortran%{_isa} see: https://docs.fedoraproject.org/en-US/packaging-guidelines/Fortran/#_packaging_of_fortran_programs 3) A Koji build with those changes in (1) and (2): https://koji.fedoraproject.org/koji/taskinfo?taskID=145919347 libquadmath is not available on s390x and aarch64, so the option will need to be disabled on those architectures. A quadmath test fails on ppc64le. Have not had time to dive into it, but it is does not block the review. Either disable quadmath on that architecture as well, or determine how to fix the failing test. 4) Make the python package explicitly require the main library. 5) Approved, please fix (1), (2), (3) and (4) before import. 6) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2481491 would be appreciated if time allows. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2467501 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202467501%23c10 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
