https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #285 from Fabio Porcedda <[email protected]> --- Issue found: - Non-English comment - Remove "%global autorelease_version 1", it's not used - Executables should be without extension so please remove the .sh extension on /usr/bin/*.sh files - Remove the %check section is meaningless, if the executables are not produce the creating of the package fail anyway because the %files list is not respected Suggestion, use pkgconfig style for BuildRequires: BuildRequires: mesa-libGL-develpkgconfig(gl) BuildRequires: mesa-libGLU-develpkgconfig(glu) BuildRequires: glew-develpkgconfig(glew) BuildRequires: openssl-develpkgconfig(openssl) BuildRequires: ncurses-develpkgconfig(ncurses) BuildRequires: glfw-develpkgconfig(glfw3) BuildRequires: vulkan-loader-develpkgconfig(vulkan) Could you explain in detail why stripping is disabled? What feature will not be available if is stripped? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c285 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
