https://bugzilla.redhat.com/show_bug.cgi?id=2477713

Mamoru TASAKA <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #10 from Mamoru TASAKA <[email protected]> ---
Well:

* License: MIT AND CC0-1.0
  - Well, "the header-only json library dependency" is packaged in mnxdom
binary packages,
    or it is just the dependency for mnxdom packages?
    If the latter, I don't think json related license should be added to the
License tag
    of this package, the License tag should show the information for this
package only.

* mnx-%{shortc}.tar.gz
  - This is not packaged in binary rpm, so this does not appear in Licens tag,
but this source
    itself must have compatible license on Fedora (as this is included in
src.rpm).
    As far as I checked this, this is under W3C, correct? (If so, this is okay
for Fedora). 

* BuildRequires: json-static
  - I don't know well why "json-static" is chosen here, just using
     BR: cmake(nlohmann_json) is enough?


* Requires: json-devel%{?_isa}
  - This is not needed. mnxdom-devel binary installs mnxdom.pc, which generates
     "Requires: pkgconfig(nlohmann_json)"

* mnxdom-soname.patch
  - This means that soname / ABI is going to be maintained on Fedora
(downstream) side?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2477713

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202477713%23c10

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to