https://bugzilla.redhat.com/show_bug.cgi?id=2453438
--- Comment #6 from Kurtis <[email protected]> --- Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10489017/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10489017/amdgpu_top-0.11.4-1.fc45.src.rpm Changes: Fixed and added licenses. > (In reply to Tom.Rix from comment #5) > I was surprised how much vendor things was pulled in for essentially a > replacement for btop. > could this be pared down? I took a look to see if I could pare anything down, but unfortunately was not able to. This seems somewhat common for rust packages within the Fedora ecosystem. > Since so much is bundled, i am wondering about this part of the guidlines > > 'all bundled crate dependencies MUST be declared with virtual Provides in > the format Provides: bundled(crate($crate)) = $version' > > Is this being done ? This is being handled automatically by cargo-rpm-macros. The %{cargo_vendor_manifest} macro in the %build section generates the cargo-vendor.txt file, to which cargo-rpm-acros automatically creates the Provides: bundled(crate(...)) = $version entries from it. I verified it by running: rpm -qp --provides amdgpu_top-0.11.4-*.x86_64.rpm | grep bundled This will show all the vendored crates declared as bundled provides. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2453438 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453438%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
