https://bugzilla.redhat.com/show_bug.cgi?id=2468030



--- Comment #4 from [email protected] ---
Spec URL: https://trix.fedorapeople.org/rocroller.spec
SRPM URL: https://trix.fedorapeople.org/rocroller-7.13.0-1.fc45.src.rpm

7.13 was released, so I updated the source to the latest.


> Looks like you have two zlib files, please update the license field and add a 
> breakdown:

>> rocroller/GPUArchitectureGenerator/isa_spec_manager/tinyxml2.cpp
>> rocroller/GPUArchitectureGenerator/isa_spec_manager/tinyxml2.h

> I'm not sure if this is technically bundled code:
> https://src.fedoraproject.org/rpms/tinyxml2

> If so, I would unbundle or add a "Provides: bundled(<tinyxml2)"

I removed these files. See these changes

BuildRequires:  tinyxml2-devel
...
# Removed bundled tinyxml
rm GPUArchitectureGenerator/isa_spec_manager/tinyxml2.cpp
rm GPUArchitectureGenerator/isa_spec_manager/tinyxml2.h
sed -i -e '/tinyxml2/d' GPUArchitectureGenerator/CMakeLists.txt
sed -i -e 's@        rocroller::isa-spec-manager@       
rocroller::isa-spec-manager tinyxml2@' GPUArchitectureGenerator/CMakeLists.txt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2468030

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468030%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to