https://bugzilla.redhat.com/show_bug.cgi?id=2467057

Jonathan Steffan <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Jonathan Steffan <[email protected]> ---
Issues:
=======
[!]: skills/skill-creator/license.txt contains the full text of the Apache
     License 2.0 but is not marked with %license. fedora-review flagged this
     as "License file LICENSE.txt is not marked as %license". This file appears
     to be a template license for users to copy when creating new skills, not a
     license declaration for openclaw itself. Please either (a) add a spec
     comment explaining why %license marking is not needed (it is a user-facing
     resource template, not a package license file), or (b) add it to the
     %license line.

I'm okay with however you want to handle this.


[!]: pdfjs-dist bundles 12 Foxit PostScript Type 1 font files (.pfb) in
     node_modules_prod/pdfjs-dist/standard_fonts/. The %prep section removes
     .ttf files but not .pfb files. Per Fedora packaging guidelines, non-fonts
     packages should avoid bundling fonts (SHOULD). Please either remove these
     font files and rely on system fonts for PDF rendering, or document in the
     spec why they are functionally required (pdfjs-dist needs built-in
fallback
     fonts to render PDFs when system fonts are unavailable).

This is a SHOULD. If you want to tackle it.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2467057

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202467057%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to