https://bugzilla.redhat.com/show_bug.cgi?id=2449216
--- Comment #26 from Fabio Valentini <[email protected]> --- (In reply to cyphar from comment #21) > (In reply to Brad Smith from comment #19) > > > > Is using clang a hard requirement? > > So, lld is a hard requirement for all architectures -- GNU ld doesn't like > the hacks you need to do to get symbol versioning working with Rust, so lld > is a requirement. > On *some* architectures (aarch64, if memory serves) rustc will pass special > linker flags based on what -linker= flag you have configured (to work around > some arch-specific issues on a per-linker basis), and in my experience that > meant you needed to use clang (-fuse-ld=lld isn't enough to stop rustc from > passing bad flags to lld). It is possible that the newest Rust versions > (>=1.90, which default to lld) don't need these workarounds but most of my > packaging / testing work was dealing with old Rust versions. So, I'm not sure whether this will work. Rust >= 1.90 only defaults to lld upstream, and only for x86_64-unknown-linux targets AIUI - and as far as I know, this change hasn't made it to Fedora - we still use GNU ld by default everywhere. We also need to pass some special linker flags / scripts that I'm not sure lld supports (but it might?). In the latest submission, you're now also mixing and matching "-a" and "-f capi" feature flags for the %cargo_* macros - this is a bad idea, it will give you inconsistent results and potentially unnecessary recompilations. I would recommend to pass "-a" only to "%cargo_generate_buildrequires" and pass "-f capi" to all other macros. That should make sure that the settings passed to build, install, and license summary are the same. And it looks like at least some of the remaining test failures are known upstream - it would be great if you could add links to the corresponding tickets to the explanation why they're skipped. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2449216 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202449216%23c26 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
