https://bugzilla.redhat.com/show_bug.cgi?id=2424814
--- Comment #3 from Benson Muite <[email protected]> --- (In reply to Georg Sauthoff from comment #2) > A few comments: > > > # disable bindings for now as python does not have > > # have metadata and some perl tests fail > > Duplicated word 'have'. Thanks. Updated. > > > BuildRequires: mimalloc-devel > > Is this really required? > The README states: > > > - libmimalloc: faster memory allocation, but usually not worth the hassle. > Can leave it out. > > BuildRequires: libasan > > BuildRequires: libubsan > > Are they used in the test suite? Removed. > > > rm jsmn/jsmn.h > > ln -s /usr/include/jsmn/jsmn.h jsmn/jsmn.h > > The symlink is superfluous, because the compiler will consult probe > /usr/include and find there jsmn/jsmn.h as well. > This is needed. It is not automatically picked up https://koji.fedoraproject.org/koji/taskinfo?taskID=145214409 > > # Json reader tests give errors > > Patch: json-test.patch > > It seems the patch thus disables JSON and a few other tests. > In that case a comment to that extend would be useful. > Done. > > # Downloaded from Ubuntu Keyserver > > # > > https://keyserver.ubuntu.com/pks/lookup?search=2895A881D34270FABFE8F747B4F63339E65D6414&fingerprint=on&op=index > > Source2: 2895a881d34270fabfe8f747b4f63339e65d6414.asc > > The official keyring of the gnu project is: > https://ftp.gnu.org/gnu/gnu-keyring.gpg > > Hence perhaps it makes sense to reference that. Done. > > > %{_infodir}/LibreDWG.info* > > The manual appears to be licensed under the GFDL. Does the .spec license tag > cares about documentation licenses? > Added. > > Apparently, the compile/check is a bit memory hungry, i.e. it killed my VM, > yet another example where swap was completely useless and just prolonged a > weird system state, > instead of quickly out-of-memory killing the offending process. > > I'll re-execute fedora-review within a larger VM, tomorrow. Thanks. spec: https://fed500.fedorapeople.org/libredwg.spec srpm: https://fed500.fedorapeople.org/libredwg-0.13.3-1.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2424814 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202424814%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
