https://bugzilla.redhat.com/show_bug.cgi?id=2439787
Carl George 🤠<[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Carl George 🤠<[email protected]> --- > - /usr/lib/cmake/args/*.cmake files should be installed in the arch specific > lib dir so the %{_lib} macro should be used and for this reason the package > should be arch-specific instead of noarch. Per the guidelines for header-only libraries, the top level package is archful, and the subpackage is noarch. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries > - At least the README.md should be included as %doc Done. > - from the -devel description "contains libraries and header files" libraries > should be removed because is header-only Good catch, I copied and pasted the usual devel boilerplate but didn't think about adjusting it for the fact that this package is header-only. > Updating to 6.4.11 should put the files in the above mentioned locations. Updated and adjust the file locations to match. However %{_prefix}/lib/cmake/args still needs to be included for now because it contains args-config-version.cmake, even in the latest version. I see there is another `DESTINATION lib/cmake/args` upstream, perhaps that needs to be changed to `DESTINATION ${CMAKE_INSTALL_DATADIR}/cmake/args` as well. IMO it's not worth diverging downstream because of how cmake will check multiple paths, and once upstream aligns things I can adjust the package to match. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10431155-args/args.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/10431155-args/args-6.4.15-1.fc45.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2439787 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202439787%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
