https://bugzilla.redhat.com/show_bug.cgi?id=2460762
--- Comment #5 from Carl George 🤠<[email protected]> --- Since your last update v0.14.0 has been tagged upstream. Please update to that version. ================================================================================ licensecheck turned up some additional licenses that need to be included in the license tag. ./aiokafka/record/_crecords/crc32c.c: Zlib ./aiokafka/record/_crecords/crc32c.h: BSD-2-Clause ================================================================================ Some of the python build requirements are picked up automatically by %pyproject_buildrequires and should not be duplicated. Also it looks like the tests pass even without the docker one, probably because you're not using the --docker-image flag. Please remove the following: * python3dist(cython) * python3dist(docker) * python3dist(cramjam) https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatically-generated-dependencies:~:text=Dependencies%20covered%20by%20the%20generators%20SHOULD%20NOT%20be%20repeated%20in%20the%20%2Espec%20file%2E ================================================================================ The `all` extra covers the rest of the extras, so the %pyproject_buildrequires argument can just be `-x all`. ================================================================================ The license file is automatically included in the dist-info directory and marked appropriately, so the explicit license in %files is a duplicate and should be removed. /usr/lib64/python3.14/site-packages/aiokafka-0.13.0.dist-info/licenses/LICENSE /usr/share/licenses/python3-aiokafka/LICENSE You can add a safety check for this by using the `-l` flag with %pyproject_save_files. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#:~:text=%2Dl%3A%20Declare%20that%20a%20missing%20license%20should%20terminate%20the%20build%2E ================================================================================ In %check the ${tests_dir} variable doesn't seem to be defined anywhere, so it should probably be removed. ================================================================================ fedora-review flagged that this package depends on the deprecated python-async-timeout. Normally new packages are not allowed to be added if they depend on deprecated packages. In this case, since it is an unretirement of an existing package, I think we can waive that as long as it is noted in a spec file comment (my suggestion would be right above %pyproject_buildrequires). There is already an upstream issue that can be referenced in the comment. https://github.com/aio-libs/aiokafka/issues/1123 https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/#_consequences_of_a_package_being_deprecated ================================================================================ Optional readability improvements: * the %{owner} macro is only used once, so I would remove it and just use the value directly * Source0 can be shortened up by using %{url} (as long as it is moved after the URL tag) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2460762 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202460762%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
