https://bugzilla.redhat.com/show_bug.cgi?id=2432762
--- Comment #12 from [email protected] --- (In reply to Jeremy Linton from comment #11) > Right, some of the JL: comments were on areas I was making notes for > posterity (aka the license ones), and were "X" passed. > > But: there is this: > [!]: Rpmlint is run on all rpms the build produces. > JL: There are rpmlint messages which are apparently fine > But I think its complaining about the libcpptrace.so.1 which shouldn't > be in the -devel package, > and the associated missing ldconfig/symlink error goes with it. > > Which I should have JL'ed, because I still see that it looks like > %{_libdir}/libcpptrace.so.1 needs to be moved from -devel to the main > package. That is what is causing some of the rpmlint issues. The fedora > guidelines state (AFAIK/IMHO) its only the unversioned DSO that must be in > the -devel. > > And AFAIK should suppress the rpmlint error: > cpptrace.aarch64: E: no-ldconfig-symlink /usr/lib64/libcpptrace.so.1.0.4 I moved the so.1 to the main package. I think it also should be there, due to the Provides. I also added the Requires: cpptrace%{?_isa} = %{version}-%{release} to the devel package. > Also, the previous comment: > Note: %define requiring justification: %define autorelease(e:s:pb:n) > %{?-p:0.}%{lua: > JL: I guess i don't know what this is accomplishing/aka why its needed > here. > > which AFAIK shouldn't be overridden since its been in place for a while now > in fedora, is this old RHEL drippings? AKA I think you can just drop it > rather than %define'ing the global. > > Other than that I think it looks good. That is from autorelease. I do not add that, see the unprocessed spec, that will be imported: https://raw.githubusercontent.com/dschwoerer/cpptrace-review/refs/heads/main/cpptrace.spec Sorry for not mentioning that earlier. Updated links: Spec URL: https://raw.githubusercontent.com/dschwoerer/cpptrace-review/refs/heads/main/cpptrace.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/davidsch/testa/fedora-rawhide-aarch64/10421647-cpptrace/cpptrace-1.0.4-1.fc45.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2432762 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202432762%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
