https://bugzilla.redhat.com/show_bug.cgi?id=2448654
--- Comment #13 from Fabio Porcedda <[email protected]> --- (In reply to admin from comment #1) > Notes for reviewer: > > - rpmlint 3 errors are intentional 750 permissions on /var/lib/i2p and > /var/log/i2p (security: only i2p service user should access router state). > Justified in rpmlintrc (included in SOURCES/). > - no-%check-section: I2P upstream has no test suite suitable for RPM builds. > - Bundled JARs in source tarball (izpack, launch4j, gradle-wrapper, Jetty, > Tomcat) are build tooling only — not shipped in final RPM. Everything is > rebuilt from source via `ant preppkg-linux-only`. AFAIK it's not possible to use jar files even just for building. Please remove them in the %prep and use in their place BuildRequires. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies jetty is already packaged but it's an older version the 9.4.40 version, it's good enough? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2448654 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202448654%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
