https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #221 from Nicola Taibi <[email protected]> --- Subject: [Space GL] Code Review Request — Faction Starbase System Implementation Hi Fabio, I am writing to submit for your review a set of changes recently introduced into the Space GL codebase, concerning the implementation of the Faction Proprietary Starbase System. The following is a summary of the work carried out: Unique 3D Faction Architectures Twelve procedurally generated starbase designs were implemented — one per proprietary faction (IDs 10–20) plus the default Alliance base. Each design reflects its faction's aesthetic identity using existing engine primitives, with no additional GPU memory allocations. The designs are fully consistent across both the Vulkan (PBR pipeline) and FreeGLUT (OpenGL immediate mode) rendering engines. Server-Side Generation The generate_galaxy() function was updated to distribute starbase ownership randomly across all eleven proprietary factions, replacing a previous hard-coded assignment to the Alliance faction. A new [ STARBASES BY FACTION ] section was added to the server's Astrometrics Report, displayed at startup. Network Serialization Bugfix A critical bug was resolved in logic.c: the faction field of NPCBase was being overwritten with a literal 0 during NetObject packing, causing both rendering clients to always display Alliance-style bases regardless of actual ownership. Faction Defense AI A server-side defense mechanism was introduced: when a player attempts to dock with a starbase belonging to a different faction, the base opens fire at 3 shots per second (20-tick cooldown at 60 Hz), targeting shields and hull progressively. The response is transmitted as a standard NetBeam event and rendered in real-time by both clients via the shared IPC queue. Diagnostic Tool spacegl_diag was updated to display faction-specific base labels (e.g., "Korthian Base") using the existing get_species_name() utility. A full project rebuild was performed following all changes. All targets compiled successfully with zero warnings and zero errors. Please do not hesitate to contact me should you require any clarification. Kind regards, Nicola Taibi Fedora 43: Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10415449-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10415449-spacegl/spacegl-2026.05.01.03-1.fc43.src.rpm Fedora 44: Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-44-x86_64/10415449-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-44-x86_64/10415449-spacegl/spacegl-2026.05.01.03-1.fc44.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c221 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
