https://bugzilla.redhat.com/show_bug.cgi?id=2463195
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <[email protected]> --- URL and Source0 addresses are Ok. Source archive SHA-512: 195040cf71f2db62a2da9b6b8a86a33ec24e0f2a92447ed248193a1e97ebefad01c3cf01876d9f34cef12335e0aefdddc6e0bfa3807e7859bec891ea827a0dee) is original. Ok. XS code, no noarch BuildArch is Ok. License verified from lib/Log/Fmt/XS.pm, dist.ini, LICENSE, and README. Ok. TODO: Increase 'perl(ExtUtils::MakeMaker)' minimal version to 6.78 (Makefile.PL:7). TODO: Increase 'perl(Test::More)' minimal version to 0.96 (META.json:50). The package builds and all tests pass. Ok. $ rpmlint perl-Log-Fmt-XS.spec ../SRPMS/perl-Log-Fmt-XS-0.002-1.fc45.src.rpm ../RPMS/x86_64/perl-Log-Fmt-XS-* ../RPMS/noarch/perl-Log-Fmt-XS-tests-0.002-1.fc45.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 perl-Log-Fmt-XS.x86_64: E: spelling-error ('logfmt', '%description -l en_US logfmt -> logoff') perl-Log-Fmt-XS.src: E: spelling-error ('logfmt', '%description -l en_US logfmt -> logoff') perl-Log-Fmt-XS-tests.noarch: W: no-documentation == 5 packages and 1 specfiles checked; 2 errors, 1 warnings, 16 filtered, 2 badness; has taken 0.7 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Log-Fmt-XS-0.002-1.fc45.x86_64.rpm drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/lib/.build-id/27 lrwxrwxrwx 1 root root 61 Apr 24 02:00 /usr/lib/.build-id/27/9317ace939d27d5d98663f438eff2238eaa161 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Log/Fmt/XS/XS.so drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/lib64/perl5/vendor_perl/Log drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/lib64/perl5/vendor_perl/Log/Fmt -rw-r--r-- 1 root root 1488 Apr 14 18:33 /usr/lib64/perl5/vendor_perl/Log/Fmt/XS.pm drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/lib64/perl5/vendor_perl/auto/Log/Fmt drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/lib64/perl5/vendor_perl/auto/Log/Fmt/XS -rwxr-xr-x 1 root root 23440 Apr 24 02:00 /usr/lib64/perl5/vendor_perl/auto/Log/Fmt/XS/XS.so drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/share/doc/perl-Log-Fmt-XS -rw-r--r-- 1 root root 281 Apr 14 18:33 /usr/share/doc/perl-Log-Fmt-XS/Changes -rw-r--r-- 1 root root 371 Apr 14 18:33 /usr/share/doc/perl-Log-Fmt-XS/README drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/share/licenses/perl-Log-Fmt-XS -rw-r--r-- 1 root root 19664 Apr 14 18:33 /usr/share/licenses/perl-Log-Fmt-XS/LICENSE -rw-r--r-- 1 root root 1412 Apr 24 02:00 /usr/share/man/man3/Log::Fmt::XS.3pm.gz $ rpm -q -lv -p ../RPMS/noarch/perl-Log-Fmt-XS-tests-0.002-1.fc45.noarch.rpm drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/libexec/perl-Log-Fmt-XS drwxr-xr-x 2 root root 0 Apr 24 02:00 /usr/libexec/perl-Log-Fmt-XS/t -rw-r--r-- 1 root root 1755 Apr 14 18:33 /usr/libexec/perl-Log-Fmt-XS/t/00-report-prereqs.dd -rwxr-xr-x 1 root root 6026 Apr 24 02:00 /usr/libexec/perl-Log-Fmt-XS/t/00-report-prereqs.t -rwxr-xr-x 1 root root 2067 Apr 24 02:00 /usr/libexec/perl-Log-Fmt-XS/t/leak.t -rwxr-xr-x 1 root root 179 Apr 24 02:00 /usr/libexec/perl-Log-Fmt-XS/t/log-fmt-test.t -rwxr-xr-x 1 root root 99 Apr 24 02:00 /usr/libexec/perl-Log-Fmt-XS/test File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Log-Fmt-XS-0.002-1.fc45.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libperl.so.5.42()(64bit) 1 perl(:MODULE_COMPAT_5.42.2) 1 perl(:VERSION) >= 5.20.0 1 perl(Log::Fmt) 1 perl(parent) 1 perl(warnings) 1 perl(XSLoader) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) $ rpm -q --requires -p ../RPMS/noarch/perl-Log-Fmt-XS-tests-0.002-1.fc45.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 /usr/bin/sh 1 perl(ExtUtils::MakeMaker) 1 perl(File::Spec) 1 perl(Log::Fmt) 1 perl(Log::Fmt::Test) 1 perl(Log::Fmt::XS) 1 perl(strict) 1 perl(Test::More) >= 0.88 1 perl(utf8) 1 perl(warnings) 1 perl-Log-Fmt-XS = 0.002-1.fc45 1 perl-Test-Harness 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Increase 'perl(Test::More)' minimal version to 0.96 (META.json:50). $ rpm -q --provides -p ../RPMS/x86_64/perl-Log-Fmt-XS-0.002-1.fc45.x86_64.rpm | sort -f | uniq -c 1 perl(Log::Fmt::XS) = 0.002 1 perl-Log-Fmt-XS = 0.002-1.fc45 1 perl-Log-Fmt-XS(x86-64) = 0.002-1.fc45 test@fedora-45:~/rpmbuild/SPECS $ rpm -q --provides -p ../RPMS/noarch/perl-Log-Fmt-XS-tests-0.002-1.fc45.noarch.rpm | sort -f | uniq -c 1 perl-Log-Fmt-XS-tests = 0.002-1.fc45 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Log-Fmt-XS-0.002-1.fc45.x86_64.rpm ../RPMS/noarch/perl-Log-Fmt-XS-tests-0.002-1.fc45.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=144993850). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the TODO items before building this package. Package: APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463195 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463195%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
