https://bugzilla.redhat.com/show_bug.cgi?id=2463824

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #2 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are almost ok
FIX: Please remove duplicate build-require perl(Cwd)
FIX: Please add missing BR:
     - perl(File::Temp) - t/unit/Script.t

$ rpm -qp --requires perl-App-Yath-Script-2.000016-1.fc45.noarch.rpm | sort |
uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Cwd) >= 3.75
      1 perl(File::Spec)
      1 perl(Getopt::Yath) >= 2.000008
      1 perl(goto::file)
      1 perl(Importer) >= 0.025
      1 perl-libs
      1 perl(strict)
      1 perl(warnings)
      1 /usr/bin/perl
$ rpm -qp --requires perl-App-Yath-Script-tests-2.000016-1.fc45.noarch.rpm |
sort | uniq -c | grep -v rpmlib
      1 coreutils
      1 perl(App::Yath::Script)
      1 perl-App-Yath-Script = 2.000016-1.fc45
      1 perl(App::Yath::Script::V0)
      1 perl(Config)
      1 perl(Cwd) >= 3.75
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(PerlIO::scalar)
      1 perl(strict)
      1 perl(Test2::Require::Module)
      1 perl(Test2::V0) >= 1.302199
      1 perl-Test-Harness
      1 perl(warnings)
      1 /usr/bin/bash
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-App-Yath-Script-2.000016-1.fc45.noarch.rpm | sort |
uniq -c
      1 perl(App::Yath::Script) = 2.000016
      1 perl-App-Yath-Script = 2.000016-1.fc45
      1 perl(App::Yath::Script::V0) = 2.000016
$ rpm -qp --provides perl-App-Yath-Script-tests-2.000016-1.fc45.noarch.rpm |
sort | uniq -c
      1 perl-App-Yath-Script-tests = 2.000016-1.fc45
Binary provides are Ok.

$ rpmlint ./perl-App-Yath-Script*
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
perl-App-Yath-Script-tests.noarch: W: no-documentation 
 2 packages and 1 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0
badness; has taken 0.3 s
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2463824

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463824%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to