https://bugzilla.redhat.com/show_bug.cgi?id=2449216
--- Comment #15 from Fabio Valentini <[email protected]> --- Sorry for the delay, I've had too much on my plate recently. I think using a rust2rpm.toml config file *now* will make your package maintenance life easier sooner ... so I made one, based on your current spec file (plus fixes for issues 2. and 3. below): https://decathorpe.fedorapeople.org/libpathrs/rust2rpm.toml === There's some remaining issues: 1. License tag is not correct. The License tag for the source package should just be the license of the sources, i.e. what rust2rpm generates for you ("MPL-2.0 OR LGPL-3.0-or-later"). The Licenses of statically linked library dependencies only influence the License tag of the "libpathrs" subpackage, nothing else. From the build log: ### BEGIN LICENSE SUMMARY ### # Apache-2.0 # Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT # BSD-2-Clause OR Apache-2.0 OR MIT # MIT OR Apache-2.0 # MPL-2.0 OR LGPL-3.0-or-later # Unlicense OR MIT # Zlib OR Apache-2.0 OR MIT ### END LICENSE SUMMARY ### The License tag you added does not contain the string "OR", so it can't be correct. It should look something like this: # Apache-2.0 # Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT # BSD-2-Clause OR Apache-2.0 OR MIT # MIT OR Apache-2.0 # MPL-2.0 OR LGPL-3.0-or-later # Unlicense OR MIT # Zlib OR Apache-2.0 OR MIT License: %{shrink: (MPL-2.0 OR LGPL-3.0-or-later) AND Apache-2.0 AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0) AND (Unlicense OR MIT) AND (Zlib OR Apache-2.0 OR MIT) } 2. You used the "wrong" escaping / syntax for skipping tests. It looks like you intended to filter out *four* specific tests. Instead this happened: > test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 7044 filtered > out; finished in 0.00s Just set up which tests to skip in rust2rpm.toml, it will use the correct syntax for you. And if you do, the result will be this instead: > test result: FAILED. 375 passed; 4421 failed; 6 ignored; 0 measured; 2242 > filtered out; finished in 7.74s So ... tests fail quite spectacularly. What the tests are attempting to do also looks quite suspicious (running chown?), so I'm not sure that this *can* be fixed without talking to upstream. 3. The C library .so file version is globbed in the %files list, this is not allowed. I fixed this in the linked rust2rpm.toml file. 4. The %{_includedir}/pathrs folder is unowned. Also fixed in the linked rust2rpm.toml file. === With the linked rust2rpm.toml file (and a small Cargo.toml patch to make C library package generation actually work as intended), the only thing you need to adjust manually after running is to copy the License summary and adjust the License tag in the libpathrs subpackage, nothing else. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2449216 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202449216%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
