https://bugzilla.redhat.com/show_bug.cgi?id=2463785
Dan Horák <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Dan Horák <[email protected]> --- a couple notes - you should drop the R: python3, it's automagically added by rpmbuild from the shebang - you should be able to drop the manual installation of the license and README files, the %doc and %license tags should take care of that - I would update the Source tag to use %{url} variable (value of the URL tag) for the source archive URL - I would use %{name} instead of the "fedora-active-user" string in the %install and %files section, but that's really more a personal preference than a requirement -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463785 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463785%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
