https://bugzilla.redhat.com/show_bug.cgi?id=2450774

Phil Wyett <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(philip.wyett@kath |needinfo?([email protected])
                   |enas.org)                   |



--- Comment #23 from Phil Wyett <[email protected]> ---
Hi,

Got the files, thanks.

Builds local and on COPR are good except for failure on s390x. You may wish to
investigate, fix or exclude from the build system.

Build log:
https://download.copr.fedorainfracloud.org/results/kathenas/generic-fedora-rawhide-all-with-review-not-production/fedora-rawhide-s390x/10404486-mhwaveedit/builder-live.log.gz

The version requirement is not needed here.

BuildRequires:  pkgconfig(jack) >= 0.98.0
BuildRequires:  pkgconfig(libpulse) >= 0.9.10

The below section needs to be above %changelog

%files -f %{name}.lang
%{_bindir}/%{name}
%{_datadir}/applications/%{name}.desktop
%{_datadir}/metainfo/%{name}.metainfo.xml
%{_iconsdir}/hicolor/*/apps/%{name}.png
%{_mandir}/man1/%{name}.1*

The below section needs to be above your %files

%check
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop
appstream-util validate-relax --nonet
%{buildroot}/%{_datadir}/metainfo/%{name}.metainfo.xml

The below section needs to be inserted int the files section, right at the top.

%doc AUTHORS BUGS ChangeLog NEWS README TODO
%license COPYING

Example of complete file below.

Summary:    WAV Editing Package
Name:       mhwaveedit
Version:    1.4.24
Release:    1%{?dist}
Url:        https://github.com/magnush/mhwaveedit
License:    GPL-2.0-or-later
%global     forgeurl https://github.com/magnush/mhwaveedit

%forgemeta
Source0:    %{forgesource}
Source1:    mhwaveedit.metainfo.xml

BuildRequires:  gcc
BuildRequires:  autoconf
BuildRequires:  automake
BuildRequires:  libtool
BuildRequires:  make
BuildRequires:  ladspa-devel
BuildRequires:  lame-devel
BuildRequires:  desktop-file-utils
BuildRequires:  hicolor-icon-theme
BuildRequires:  libappstream-glib

BuildRequires:  pkgconfig(alsa)
BuildRequires:  pkgconfig(gthread-2.0)
BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  pkgconfig(jack) >= 0.98.0
BuildRequires:  pkgconfig(libpulse) >= 0.9.10
BuildRequires:  pkgconfig(ogg)
BuildRequires:  pkgconfig(sdl)
BuildRequires:  pkgconfig(sndfile)
BuildRequires:  pkgconfig(portaudio-2.0)
BuildRequires:  pkgconfig(samplerate)

Requires:       hicolor-icon-theme
# For default mixer (alsamixer)
Requires:       alsa-utils

%description
mhWaveEdit is a graphical program for editing sound files.
It is completely free (GPL) and written by Magnus Hjorth.
It is intended to be user-friendly and robust.
OGG and LAME support are available if installed.

%prep
%autosetup

%build
%global _pkg_extra_cflags -std=gnu17

%configure --prefix=/usr \
        --without-arts \
        --without-esound \
        --without-oss \
        --without-sun \
        --with-double-samples

%make_build

%install
%make_install
%find_lang %{name}
install -D -p -m 644 %{SOURCE1}
%{buildroot}%{_datadir}/metainfo/%{name}.metainfo.xml

%check
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop
appstream-util validate-relax --nonet
%{buildroot}/%{_datadir}/metainfo/%{name}.metainfo.xml

%files -f %{name}.lang
%license COPYING
%doc AUTHORS BUGS ChangeLog NEWS README TODO
%{_bindir}/%{name}
%{_datadir}/applications/%{name}.desktop
%{_datadir}/metainfo/%{name}.metainfo.xml
%{_iconsdir}/hicolor/*/apps/%{name}.png
%{_mandir}/man1/%{name}.1*

%changelog
* Fri Mar 27 2026 peterbb <[email protected]> - 1.4.24-1
- Reintroduce to Fedora

Regards

Phil


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2450774

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202450774%23c23

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to