https://bugzilla.redhat.com/show_bug.cgi?id=2461078
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|NEW |ASSIGNED --- Comment #3 from Ben Beasley <[email protected]> --- The file test_data/rebuild.sh has a /usr/bin/env shebang and generates an unwanted dependency on bash. Try something like this in rust2rpm.toml: [scripts.prep] pre = [ """\ # Do not generate a dependency on the bash shell chmod a-x test_data/rebuild.sh # Remove the shebang because we unset the execute bit and because it uses env, # https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines. sed -r -i '1{/^#!/d}' test_data/rebuild.sh\ """, ] Upstream has assigned an “overall” license of (MIT OR Apache-2.0), but this does not account for all of the licenses of test data fonts, and we must do so: https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis, https://docs.fedoraproject.org/en-US/legal/identify/. Fortunately, test_data/README.md does attempt to account for all of these licenses. Since it looks thorough, I haven’t attempted to second-guess this accounting, but I spot-checked and didn’t find any obvious gaps or errors. I think we can safely take test_data/README.md at face value. Try something like this, in rust2rpm.toml: [package] cargo-toml-patch-comments = [ """\ Add OFL-1.1, Apache-2.0 and Unicode-3.0 terms to the SPDX license expression to \ account for fonts in test_data/; see test_data/README.md for an accounting of \ which licenses apply to which fonts.\ """, ] Then, using “rust2rpm -p”, change the line license = "MIT OR Apache-2.0" to license = "(MIT OR Apache-2.0) AND Apache-2.0 AND OFL-1.1 AND Unicode-3.0" Otherwise, this looks sensible. While https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ generally prohibits packaging fonts bundled in other packages, I think this package is fine because the fonts are to be used solely as binary test data files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2461078 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202461078%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
