https://bugzilla.redhat.com/show_bug.cgi?id=2463266
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flags| |fedora-review? Assignee|[email protected] |[email protected] Status|NEW |ASSIGNED --- Comment #1 from Fabio Valentini <[email protected]> --- Taking this review. Initial comments: 1. This isn't following the Naming guidelines for Rust packages. It's not a Rust crate packaged from crates.io, so it MUST NOT use the "rust-" name prefix. In general, I would recommend that you just follow the template documented here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_non_crate_rust_project It should also make some other things easier (i.e. no defining "cargo_install_lib 0" necessary). 2. The package isn't following the guidelines for snapshot based versions. The snapshot information should now be in Version, not in Release. Use something like "Version: 0~%{commitdate}.git%{shortcommit}" instead. 3. The package uses %autochangelog but not %autorelease. This is often broken. Either use both or neither, and you SHOULD use both. 4. The "License" tag is incomplete. Even without having built the package, I am 100% certain that the output of "%cargo_license_summary" during the build will not just be one line containing "MIT". The License tag needs to reflect *all* dependencies that get statically linked into the final executable. You also generate the LICENSE.dependencies file, but then don't use it. It needs to be listed as "%license LICENSE.dependencies" in the %files list. 5. The fact that the project currently builds successfully seems to be a lucky accident. The project contains a sub-crate at "gobject-ast" that is referenced as a path-based dependency, but it's not set up as a "workspace" member. This only works by accident right now, and is probably not intentional in the upstream project. It might be good to fix this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463266 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463266%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
