https://bugzilla.redhat.com/show_bug.cgi?id=2459725
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(U2FsdGVkX1@gmail. |needinfo?(philip.wyett@kath |com) |enas.org) --- Comment #4 from [email protected] --- @[email protected] Hi Phil, Thanks for the review. For the architecture: ExclusiveArch: %{zig_arches} because the package requires Zig >= 0.15 and Fedora's Zig macros currently only list the architectures where Zig is available. I would prefer to keep this tied to %{zig_arches} for now, and I am happy to enable more architectures once Zig is available and the package builds there. * The spelling warnings for "ncurses" and "systemd" are false positives. * Upstream does not appear to ship a full test suite. * I will look into enabling PIE for the Zig executable, likely by setting PIE in the Zig build or passing the appropriate Zig build option. * The vendor tarball warning appears to be against the upstream-provided vendor.tar.zst archive. I will upload an updated SRPM after these changes and trigger a new fedora-review-service build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2459725 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202459725%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
