https://bugzilla.redhat.com/show_bug.cgi?id=2418265
--- Comment #3 from Petr Pisar <[email protected]> --- URL and Souce0 are usable. Ok. Source0 archive (SHA512: ee85147ac0c3095a26c7c70cf65d4b7d099d49f6914f3cd8d05d963bdeda68ea90595cd6e5b586b06e9dfef77ae82a863caf573c74f244f7477e78fde3a4dbc1) is original. Ok. Summary verified from lib/Chemistry/Ring.pm. Ok. Description verified from lib/Chemistry/Ring.pm. Ok. No XS code, noarch BuildArch is Ok. License verified from lib/Chemistry/Ring/Find.pm, lib/Chemistry/Ring.pm, Makefile.PL, README, dist.ini. Ok. TODO: Build-require "coreutils" for %{_fixperms} macro (perl-Chemistry-Ring.spec:46). TODO: Constrain "perl(Chemistry::Mol)" dependency with ">= 0.24" (META.json:24). TODO: Constrain "perl(Statistics::Regression)" dependency with ">= 0.15" (META.json:25). FIX: Build-require "perl(strict)" (Makefile.PL:2). FIX: Build-require "perl(warnings)" (Makefile.PL:3). FIX: Build-require "perl(base)" (lib/Chemistry/Ring.pm:53). FIX: Build-require "perl(Exporter)" (lib/Chemistry/Ring.pm:53). FIX: Build-require "perl(Scalar::Util)" (lib/Chemistry/Ring.pm:54). FIX: Remove the "find %{buildroot} -type f -name '*.bs' -empty -delete" line at perl-Chemistry-Ring.spec:45. It's not needed for noarch Perl packages. FIX: Package "Changes" file as a documenation. FATAL: This package build-require "perl(Chemistry::File::SMILES)" which is not provided by any package in Fedora. Please package that first. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418265 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418265%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
