https://bugzilla.redhat.com/show_bug.cgi?id=2456922
Neal Gompa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #20 from Neal Gompa <[email protected]> --- Some spec feedback here: > Source0: > %{URL}/archive/refs/tags/v%{version}.tar.gz#/%{name}-%{version}.tar.gz This should be "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz" Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags > BuildRequires: qt6-qtbase-devel > BuildRequires: qt6-qtconnectivity-devel These should be converted to their "cmake()" virtual names. For example, your CMakeLists has the following: > find_package(Qt6 REQUIRED COMPONENTS Core Bluetooth DBus) That would become: BuildRequires: cmake(Qt6Core) BuildRequires: cmake(Qt6Bluetooth) BuildRequires: cmake(Qt6DBus) > BuildRequires: pulseaudio-libs-devel This is requested via pkgconfig in CMake, it seems: > pkg_check_modules(PULSEAUDIO REQUIRED libpulse) So this would become BuildRequires: pkgconfig(libpulse) > %build > pushd src > %cmake -DLINUXPODS_BUILD_GUI=OFF > %cmake_build > popd This should be broken up into %conf and %build like so %conf pushd src %cmake -DLINUXPODS_BUILD_GUI=OFF popd %build pushd %cmake_build popd > * Wed Apr 15 2026 Nick <[email protected]> - 1.0.2-1%{?dist} This formatting isn't correct. The author needs to be *you* with a contactable email address. You are permitted to obscure it from spam harvesting, but the idea is that people need to be able to contact you if needed. You also shouldn't put "%{?dist}" there. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/manual-changelog/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2456922 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202456922%23c20 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
