https://bugzilla.redhat.com/show_bug.cgi?id=2453357
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Cristian Le <[email protected]> --- Overall lgtm, just one license issue to resolve - Please check and verify with upstream what the license state of this crate is. Here is what licensecheck reported ``` *No copyright* Apache License 2.0 --------------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/LICENSE rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/config.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/generator.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/lib.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/root_package.json rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/workspace_package.json *No copyright* BSD 2-Clause License ----------------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/git_package_with_branch.json *No copyright* MIT License -------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/git_package.json *No copyright* The Unlicense ---------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/crates_io_package.json Apache License 2.0 ------------------ rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/README.md rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/format.rs Apache License 2.0 and/or MIT License ------------------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/main.rs Unknown or generated -------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/.cargo_vcs_info.json rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/CHANGELOG.md rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/Cargo.lock rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/Cargo.toml rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/Cargo.toml.orig rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/cli.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/platform.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/purl.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/cli.rs ``` The `.json` files can be ignored, but the `src/main.rs` is valid. - (non-blocker) `rust-cargo_metadata0.18` compat package is being picked up -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2453357 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453357%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
