https://bugzilla.redhat.com/show_bug.cgi?id=2434112
--- Comment #12 from Ben Beasley <[email protected]> --- It looks like you have edited the output of rust2rpm to remove these lines, -%license %{crate_instdir}/LICENSE-APACHE -%license %{crate_instdir}/LICENSE-MIT presumably to stop fedora-review from complaining about duplicate entries in the files list. (The second entry for each of these files is the recursive %{crate_instdir}/.) This “duplication,” though, is harmless (it doesn’t result in duplicate installed files), it’s due to a reasonable rust2rpm design decision (otherwise all the contents of %{crate_instdir}/ would have to be listed individually in order to mark only some of them as %license or %doc without duplication), and these lines are *necessary*, because license files *must* be marked with the %license directive: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text. Ideally, the metadata patch would link https://github.com/emabee/rust-cond_sync/pull/1. In general, metadata patches should be documented in terms of what they do and why, and the upstream status (https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/) of these changes. You can use package.cargo-toml-patch-comments in rust2rpm.toml for this. You might consider adding exclude = ["scripts/**"] to Cargo.toml. The script scripts/qualify is really only for upstream development, it has the execute bit set, its shebang line expects it to run with https://github.com/DanielKeep/cargo-script, and the /usr/bin/env in the script is counter to https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines. It seems cleaner to just omit it. You could even suggest the change upstream, since it’s not useful to people building the published crate with cargo, either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2434112 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202434112%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
