https://bugzilla.redhat.com/show_bug.cgi?id=2434109
--- Comment #19 from Ben Beasley <[email protected]> --- I generally agree with the review by Troels, above. (In reply to Troels Arvin from comment #16) > [x]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define autorelease(e:s:pb:n) > %{?-p:0.}%{lua: > -> This seems normal with Rust packages. It’s normal, and it’s due to expansion of rpmautospec macros. This doesn’t happen in source RPMs built with rpmbuild -bs, but it does happen in those built with fedpkg srpm. The advice to prefer %global is dubious and/or outdated, anyway; see https://pagure.io/packaging-committee/issue/1449. I confirmed that the package builds on all architectures: https://koji.fedoraproject.org/koji/taskinfo?taskID=144462512 I confirmed that the license metadata appears correct. However, I did find one issue: the file LICENSE looks like this: Copyright 2021 Leonhard LLC Licensed under the Apache License, Version 2.0 (the "License"); you may not use these files except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. Unfortunately, section 4(a) of the Apache-2.0 license says, “You must give any other recipients of the Work or Derivative Works a copy of this License.” Therefore, the complete license text needs to be included in the package. You should point this out upstream at https://gitlab.com/leonhard-llc/ops and ask them to add the license text, or open a PR to do so. Until upstream makes a new release with license text included, you’ll have to patch in the standard Apache-2.0 text yourself; see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2434109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202434109%23c19 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
