https://bugzilla.redhat.com/show_bug.cgi?id=2328503

Benson Muite <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(benson_muite@emai |
                   |lplus.org)                  |



--- Comment #7 from Benson Muite <[email protected]> ---
Thanks. Updated. Will exclude i386 (In reply to Phil Wyett from comment #6)
> Hi,
> 
> * Upstream 1.1.1 available and should be the version packaged.

Done.

> 
> *Build - Local: Pass
> 
> * Build - COPR: Filaures
> 
>   - Fail: i386

Can exclude this as a leaf architecture.
https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval

> 
>    
> https://copr.fedorainfracloud.org/coprs/kathenas/generic-fedora-rawhide-all-
> with-review-not-production/build/10224991/
> 
>   - NOTE: s390x builders outage at time of writing.
> 
> * Remove empty lien 72.

Why should this be removed? It helps make the spec file easier to read.

> 
> * Line 82 - BuildRequires:  openmpi-devel
> 
>   - Should this be with other 'BuildRequires' or should it be a 'Requires'.
> 

This is correct.  Once the build is done, Requires are automatically generated
where shared libraries are linked.

> Regards
> 
> Phil

spec: https://fed500.fedorapeople.org/SpFFT.spec
srpm: https://fed500.fedorapeople.org/SpFFT-1.1.1-1.fc43.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2328503

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328503%23c7

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to