https://bugzilla.redhat.com/show_bug.cgi?id=2456922
--- Comment #4 from Nick <[email protected]> --- Thanks Dan and Leigh for the review — much appreciated, especially as this is my first package. I updated the spec addressing all points: * Source0 now follows the SourceURL guideline (%{URL}/...) * Removed the need for hicolor-icon-theme (GUI front-end is no longer shipped) * Updated sub-package dependency to use %{?_isa} * Fixed directory ownership (no longer creating /usr/share/librepods/) I also addressed several rpmlint issues and improved licensing: * Added SPDX headers to project files * Removed non-redistributable assets (SF Symbols font) * Added man pages and a basic %check section * Declared bundled QR library Spec URL: https://raw.githubusercontent.com/Explor3Universe/LinuxPods/main/linuxpods.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/explor3universe/linuxpods/srpm-builds/10311771/linuxpods-0.2.0-2.fc43.src.rpm COPR build: https://copr.fedorainfracloud.org/coprs/build/10311771 Please let me know if anything else needs to be fixed. Thanks again! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2456922 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202456922%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
