https://bugzilla.redhat.com/show_bug.cgi?id=2450007
Mikel Olasagasti Uranga <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Mikel Olasagasti Uranga <[email protected]> --- - Add explicit BuildRequires on make > %make_build - Why custom __golang_extldflags are required? Add a comment > %global __golang_extldflags -Wl,-z,lazy -Wl,--export-dynamic - Current template for the %prep part does the following: > %prep > %goprep -p1 > tar -xf %{S:1} While you're doing: > %goprep -A > %setup -q -T -D -a1 %{forgesetupargs} > tar xf %{SOURCE3} > %autopatch -p1 Feels a pre 1.19 go2rpm template was used and later reapplied somehow. It's purely cosmetic request, but if you could normalize it would be better. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2450007 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202450007%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
