https://bugzilla.redhat.com/show_bug.cgi?id=2448306
--- Comment #2 from Aleksei Bavshin <[email protected]> --- Spec URL: https://alebastr.fedorapeople.org/review/python-typelets/python-typelets.spec SRPM URL: https://alebastr.fedorapeople.org/review/python-typelets/python-typelets-1.1-1.fc44.src.rpm Thanks for the review! >(In reply to Benson Muite from comment #1) > Comments: > a) Please change > %files -n python3-typelets -f %{pyproject_files} > > to > > %files -n python3-typelets -f %{pyproject_files} > %doc README Fixed, thanks! > c) Please add django as a build dependency. It is listed in the > development requirements: I have to disagree with this comment. I intentionally omitted the django BR, because it is not needed for the build (note how %pytest fully passes without it), and must not be a runtime requirement. Also, I need to remind that %pyproject_check_import is NOT a test, and is optional if the upstream test suite can be run instead (see %py3_check_import/%pyproject_check_import in the guidelines). However, it works well for verifying that usable parts of typelets don't import anything unexpected. I hope the updated comment in the spec explains that better. If you're not convinced, I can make a compromise solution: remove 'typelets.django.*' from the package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2448306 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202448306%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
