https://bugzilla.redhat.com/show_bug.cgi?id=2454481
Bradan Fleming <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Bradan Fleming <[email protected]> --- I'm not a reviewer, but I have a few notes: - The spec filename should be %{name}.spec (ladybug.spec -> ladybug-cli.spec). - All of the libraries seem to be vendored upstream (https://github.com/LadybugDB/ladybug/tree/main/third_party) without any indication of this in the spec file. You might want to link against packaged versions of those libraries instead. More info: https://fedoraproject.org/wiki/Bundled_Libraries - The mock build failed on rawhide when I tried it (seemingly due to fixed-width types not being defined in one of the vendored libs). You can test this with "fedpkg mockbuild". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2454481 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202454481%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
