https://bugzilla.redhat.com/show_bug.cgi?id=2452955
--- Comment #3 from Steve Traylen <[email protected]> --- Thank you for the review: Spec URL: https://straylen.web.cern.ch/rpms/python-sphinx-feature-classification/python-sphinx-feature-classification.spec SRPM URL: https://straylen.web.cern.ch/rpms/python-sphinx-feature-classification/python-sphinx-feature-classification-2.1.0-1.fc43.src.rpm Main change is I have now enabled the documentation build as I have patched cliff in rawhide for python3.15a. Addressing your comments: - Dist tag is present. The release is Release: %{autorelease} The is normal when rpmautospec is in use with a spec using %autorelease, it is extended by the dist tag as per the .src.rpm name above. Maybe you mean something else ? - Directory ownership: The package creates directories `/usr/lib/python3.14` and `/usr/lib/python3.14/site-packages` without explicitly owning them. The package must own all directories it creates. This can be fixed by adding these directories to the `%files` section. (See Filesystem Layout and Packaging Guidelines) The package requires: rpm -qp --requires ./results/python3-osc-placement-4.8.0-1.fc45.noarch.rpm python(abi) = 3.14 and this bring in the python3-libs package which owns those directories. Significantly they will never be unowned. d - License field mismatch: This package is pretty well licensed I would say. * LICENSE file is good * pyproject.toml file is explicit Most of the "real" source files have headers on as well. The remaining files are things like .reno.conf (used for tests) , pyproject.yaml belong in the not relevant category, these are build scripts. There are certainly no files that contradict this is Apache-II all over. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2452955 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202452955%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
