https://bugzilla.redhat.com/show_bug.cgi?id=2452765
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Ben Beasley <[email protected]> --- You should explain/justify what is happening in the metadata patch. Something like this, in rust2rpm.toml, would do nicely: [package] cargo-toml-patch-comments = [ "Update webbrowser to 1.0 (upstream wants 0.5)", ] Ideally, you would also suggest the change upstream. Fortunately, someone already has, so you can just link that PR: cargo-toml-patch-comments = [ """\ Update webbrowser to 1.0 (upstream wants 0.5): https://github.com/optozorax/quad-url/pull/2\ """, ] Similarly, tests shouldn’t be disabled without an explanation, something like: [tests] run = false comments = [ "Unpackaged dev-dependencies egui-macroquad, macroquad, and egui", ] Although it’s not really hurting anything, you could choose to exclude js/quad-url.js in your metadata patch since it’s only for WASM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2452765 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202452765%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
