https://bugzilla.redhat.com/show_bug.cgi?id=2453339

Ben Beasley <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Ben Beasley <[email protected]> ---
It looks like you modified the output of rust2rpm by removing the lines marking
LICENSE-APACHE and LICENSE-MIT as license files, and README.md as
documentation.

--- c/rust-font-types.spec      2026-03-31 22:42:23.191868272 +0100
+++ srpm-unpacked/rust-font-types.spec  2026-03-31 01:00:00.000000000 +0100
@@ -30,9 +30,6 @@
 use the "%{crate}" crate.

 %files          devel
-%license %{crate_instdir}/LICENSE-APACHE
-%license %{crate_instdir}/LICENSE-MIT
-%doc %{crate_instdir}/README.md
 %{crate_instdir}/

 %package     -n %{name}+default-devel

Why?

If it is because fedora-review gives a finding about “Package does not contain
duplicates in %files.” otherwise, this is not a serious problem, and this
diagnostic is reported for every rust2rpm-packaged submission. This just means
the files were matched in the files list more than one way, not that there are
duplicate packaged copies of the files, and this due to reasonable design
decisions in rust2rpm. Removing these lines means that license and
documentation files are not correctly marked as such, which *is* a real defect,
e.g.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2453339

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453339%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to