https://bugzilla.redhat.com/show_bug.cgi?id=2446445



--- Comment #4 from Benson Muite <[email protected]> ---
Mostly seems ok. Can the URL be updated to:

https://github.com/msokalski/delabella

Can the source be updated to
%{url}/archive/V%{version}/delabella-%{version}.tar.gz

Please also change:

%{_libdir}/libdelabella.so.%{version}
%{_libdir}/libdelabella.so.%(echo %{version} | cut -d. -f1)

to

%{_libdir}/libdelabella.so.2{,.*}

Soname changes should be tracked and changed manually so that
changes can be announced to prevent other software from failing
to work when there is an ABI change.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2446445

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202446445%23c4

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to