https://bugzilla.redhat.com/show_bug.cgi?id=2447810



--- Comment #3 from Ben Beasley <[email protected]> ---
If you’re going to disable the tests, you should justify it, something like (in
rust2rpm.toml):

  [tests]
  run = false
  comments = [
      "Tests expect to be run in the workspace; they require a test_util
crate",
  ]

However, it turns out that you can patch out the import of the test_util
workspace crate, which is currently entirely unused for vergen-lib in
particular, and run all the included tests after all, something like this:

  diff -Naur vergen-lib-9.1.0-original/src/lib.rs vergen-lib-9.1.0/src/lib.rs
  --- vergen-lib-9.1.0-original/src/lib.rs        2006-07-24 02:21:28.000000000
+0100
  +++ vergen-lib-9.1.0/src/lib.rs 2026-03-29 08:25:03.328066431 +0100
  @@ -241,7 +241,9 @@
   #![cfg_attr(coverage_nightly, feature(coverage_attribute))]

   #[cfg(test)]
  -use {temp_env as _, test_util as _};
  +// Downstream patch: the test_util workspace crate dep. is currently unused
  +// use {temp_env as _, test_util as _};
  +use {temp_env as _};

   pub mod constants;
   mod emitter;

That would be even better. For an example of tracking a patch in rust2rpm.toml,
see
https://src.fedoraproject.org/rpms/rust-icu_provider/blob/4e61c9aed99c6e357720128819be78926b664d91/f/rust2rpm.toml#_6.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2447810

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202447810%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to