https://bugzilla.redhat.com/show_bug.cgi?id=2249395



--- Comment #33 from nucleo <[email protected]> ---
I still think zlib-ng-compat-static is undesirable and can be changed to
zlib-ng-compat-devel after replacing patch 02-png-module-fix.patch with new
patch

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -119,7 +119,7 @@ endif()

 set(CMAKE_C_STANDARD 11)
 set(CMAKE_CXX_STANDARD 14)
-set(CMAKE_FIND_PACKAGE_PREFER_CONFIG ON)
+set(CMAKE_FIND_PACKAGE_PREFER_CONFIG OFF)

 # Optional features
 #

This patch also fixes issue with png in Rawhide.



Another issues from
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249395-86box/fedora-rawhide-x86_64/10260534-86Box/fedora-review/review.txt

License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "*No copyright* GNU General Public License, Version 2", "GNU
     General Public License v2.0 or later", "BSD 3-Clause License", "zlib
     License", "MIT License", "BSD 2-Clause License and/or GNU General
     Public License v2.0 or later", "GNU Library General Public License v2
     or later", "*No copyright* MIT License", "BSD 2-Clause License", "FSF
     Unlimited License [generated file]", "Historical Permission Notice and
     Disclaimer - sell variant [generated file]", "GNU Lesser General
     Public License v3.0 or later", "Khronos License", "GNU Lesser General
     Public License v2.1 or later", "BSD 2-Clause License and/or BSD
     2-clause NetBSD License". 1567 files have unknown license. Detailed
     output of licensecheck in /var/lib/copr-
     rpmbuild/results/86Box/licensecheck.txt

You can run licensecheck recursively on sources and add something like this
License: GPL-2.0-only AND GPL-2.0-or-later AND MIT AND BSD-3-Clause AND
(BSD-2-Clause OR GPL-2.0-or-later) AND zlib AND LGPL-2.0-or-later

There are in sources also other licenses should be included in %license
src/disk/minivhd/LICENSE and src/cpu/softfloat3e/COPYING.txt

Package uses nothing in %doc for runtime.
README.md README-UNIX-MODE-WITH-OSD.txt SECURITY.md can be added in %doc


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2249395

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249395%23c33

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to