https://bugzilla.redhat.com/show_bug.cgi?id=2445513



--- Comment #5 from Mikel Olasagasti Uranga <[email protected]> ---
Thanks for your patience Emir.

Spec is mostly good, but have a few comments:

- rpmlint warning: 

> # Fix spurious-executable-perm warning from rpmlint
> chmod -x SYNTAX-REFERENCE.md

This is fixed upstream, so remove for next release

https://github.com/projectdiscovery/nuclei/pull/7282

- tests:

> %if %{with check}
> # Upstream includes many integration tests requiring network access,
> # DNS resolution, remote template downloads, and headless browsers.
> # These cannot run in the restricted mock/Koji build environment.
> # Run only unit-test packages.
> go test -v ./pkg/utils/...
> go test -v ./pkg/workflows
> go test -v ./pkg/utils/monitor
> go test -v ./pkg/testutils/fuzzplayground
> %endif

Try with this:

%if %{with check}
%global ignores %{shrink:
    -s TestContextCancelNucleiEngine
    -s TestHeadlessOptionInitialization
    -s ExampleNucleiEngine
    -s ExampleThreadSafeNucleiEngine
    -s TestSimpleNuclei
    -s TestSimpleNucleiRemote
    -s TestThreadSafeNuclei
    -s TestWithVarsNuclei
    -s TestDownloadCustomTemplatesFromGitHub
    -s TestTemplateInstallation
    -s TestVersionCheck
    -s TestDslExpressions
    -s TestEvaluateWithInteractshOverrideOrder
    -s TestDNSExecuteWithResults
    -s TestMakeRequestFromModelUniqueInteractsh
    -s TestReqURLPattern
    -s TestSSLProtocol
    -s TestMultiProtoWithDynamicExtractor
    -s TestMultiProtoWithProtoPrefix

}
%gocheck2 %{ignores} -t pkg/protocols/headless -t pkg/tmplexec
%endif

- I don't think all these docs are needed: 

> %doc cmd/functional-test/targets-1000.txt cmd/functional-test/targets-150.txt
> %doc cmd/functional-test/targets-250.txt cmd/functional-test/targets.txt
> %doc cmd/functional-test/testcases.txt helm/templates/NOTES.txt
> %doc integration_tests/subdomains.txt
> %doc integration_tests/protocols/file/data/test1.txt
> %doc integration_tests/protocols/file/data/test2.txt
> %doc integration_tests/protocols/file/data/test3.txt
> %doc integration_tests/protocols/keys/README.md
> %doc 
> integration_tests/protocols/offlinehttp/data/req-resp-with-http-keywords.txt
> %doc lib/README.md pkg/input/README.md pkg/input/formats/README.md
> %doc pkg/js/CONTRIBUTE.md pkg/js/DESIGN.md pkg/js/THANKS.md
> %doc pkg/js/devtools/README.md pkg/js/devtools/bindgen/INSTALL.md
> %doc pkg/js/devtools/bindgen/README.md pkg/js/devtools/scrapefuncs/README.md
> %doc pkg/js/devtools/tsgen/README.md pkg/js/generated/README.md
> %doc pkg/tmplexec/README.md pkg/tmplexec/flow/README.md
> %doc pkg/tmplexec/multiproto/README.md static/regression-cycle.md


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2445513

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445513%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to