https://bugzilla.redhat.com/show_bug.cgi?id=2417176
Scott K Logan <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #13 from Scott K Logan <[email protected]> --- Some early thoughts taking a look at the spec: 1. The %{_includedir}/kdl/ directory should be listed directly in the spec. In addition to the cleaner spec Sayan mentioned, this package needs to "own" the directory or it will be left on disk when the package is uninstalled. Same for %{_datadir}/orocos_kdl/. 2. The doc package should either depend on the base package or include its own copy of the license. 3. Consider replacing `ExcludeArch: i386` with `ExcludeArch: %{ix86}` 4. I don't think the `*.debug` file should be explicitly listed - shouldn't that be part of the automatic debuginfo package? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2417176 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417176%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
