https://bugzilla.redhat.com/show_bug.cgi?id=2443717



--- Comment #3 from Neal Gompa <[email protected]> ---
Initial spec review:

> BuildRequires:  xorg-x11-server-Xvfb

Can this be swapped out for "wlheadless-run" or "xwfb-run"?

> Requires(post): /usr/sbin/update-alternatives
> Requires(postun): /usr/sbin/update-alternatives

Can we get rid of alternatives and just make it mutually exclusive packages
instead?

Some kind of Provides+Conflicts stanza with a virtual name? e.g.

Provides: devel(wxWidgets)
Conflicts: devel(wxWidgets)

Or something else, I guess...

> %{_libdir}/libwx_gtk3u_adv-*.so.%{sover}*

The soversion glob is too greedy, per
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files

Also, some kind of bcond to make it so that if it's the default version, the
package provides the unversioned names so it gets pulled in by default.

Finally, could we consider switching from Autotools to CMake? It appears to be
supported:
https://github.com/wxWidgets/wxWidgets/blob/master/docs/doxygen/overviews/cmake.md


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2443717

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202443717%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to