https://bugzilla.redhat.com/show_bug.cgi?id=2445693
Neal Gompa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Assignee|[email protected] |[email protected] CC| |[email protected] Status|NEW |POST --- Comment #2 from Neal Gompa <[email protected]> --- Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correct, license data is correctly installed * Package has no serious issues detected by rpmlint A couple of packaging things to update, though: > %build > %meson > %meson_build Unless you need to support EPEL9 and older, please consider splitting this into %conf and %build sections like so: %conf %meson %build %meson_build > Enhances: git This should be "Enhances: git-core" instead. I'm fine with these being resolved on import, though. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2445693 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445693%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
