https://bugzilla.redhat.com/show_bug.cgi?id=2348475
Phil Wyett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |) --- Comment #5 from Phil Wyett <[email protected]> --- Hi Chris, * I would do a bit of readability separation. Is: Name: virtnbdbackup Version: 2.38 Release: 1%{?dist} Summary: Backup utility for libvirt License: GPL-3.0-or-later URL: https://github.com/abbbi/%{name} Source0: https://github.com/abbbi/%{name}/releases/download/v%{version}/%{name}-%{version}.tar.gz BuildArch: noarch BuildRequires: findutils, sed BuildRequires: python3-devel BuildRequires: python3-libnbd >= 1.5.5 Requires: nbdkit-python-plugin Requires: nbdkit-server Requires: openssh-clients Requires: python3-libnbd >= 1.5.5 Requires: qemu-img Suggested: Name: virtnbdbackup Version: 2.38 Release: 1%{?dist} Summary: Backup utility for libvirt License: GPL-3.0-or-later URL: https://github.com/abbbi/%{name} Source0: https://github.com/abbbi/%{name}/releases/download/v%{version}/%{name}-%{version}.tar.gz BuildArch: noarch BuildRequires: findutils, sed BuildRequires: python3-devel BuildRequires: python3-libnbd >= 1.5.5 Requires: nbdkit-python-plugin Requires: nbdkit-server Requires: openssh-clients Requires: python3-libnbd >= 1.5.5 Requires: qemu-img * I would move: %generate_buildrequires %pyproject_buildrequires to just above the '%build' section. I would also add '-t' and the end of line '%pyproject_buildrequires'. See example linked to below. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file * '%setup -q' has been replaced by '%autosetup'. * I would be inclined to remove the old version requirement depends on 'python3-libnbd >= 1.5.5'. - Also look at if the requires for te above is needed. Regards Phil -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2348475 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202348475%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
