https://bugzilla.redhat.com/show_bug.cgi?id=2323713
Phil Wyett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(pbrobinson@gmail. | |com) --- Comment #20 from Phil Wyett <[email protected]> --- (In reply to Peter Robinson from comment #16) > > Issue I see is 'tests' in the package but no '%check' section with test > > triggering. > > The tests need external connectivity so they fail in the constrained build > environment so I never enabled them, also given it's modbus, a physical HW, > I'm not sure of the value of running the tests. I can add them to the spec > wrapped in an if tests for completeness if you insist. No need to add the tests after looking at them. One thing to fix is 'spectool -g -R <specfile>'. philwyett @ ks-kenobi ~/Development/rpm_build >> spectool -g -R SPECS/modpoll.spec Downloading: https://github.com/gavinying/modpoll/archive/1.6.0.tar.gz#/modpoll-1.6.0.tar.gz Download failed: 404 Client Error: Not Found for url: https://codeload.github.com/gavinying/modpoll/tar.gz/1.6.0#/modpoll-1.6.0.tar.gz Change 'Source0' to line below. Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz Regards Phil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2323713 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202323713%23c20 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
