https://bugzilla.redhat.com/show_bug.cgi?id=2446921
Benson Muite <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Benson Muite <[email protected]> --- Need link to raw spec file: spec: https://gitlab.com/mumbricht/OpenABF/-/raw/fedora-v2.0.0/pkg/rpm/openabf.spec srpm: https://download.copr.fedorainfracloud.org/results/mumble07/OpenABF/srpm-builds/10216008/openabf-2.0.0-1.src.rpm Would add BuildRequires: doxygen and then try to build the documentation and check if it is useful. It is not a must to build and ship documentation though.. Docbook documentation is better than html for packaging as it is much smaller. It can be viewed using Yelp. Would also try to run tests, add BuildRequires: gtest-devel BuildRequires: gmock-devel then add a section %check %ctest The cmake files should not be installed in lib on anything other than i686, modify the CMakeLists.txt file to use GNUInstallDirs: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html or move the folder to %{_libdir} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2446921 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202446921%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
