https://bugzilla.redhat.com/show_bug.cgi?id=2445610
--- Comment #7 from Artur Frenszek-Iwicki <[email protected]> --- A couple more details that I missed earlier: > BuildRequires: fpc FPC does not support all the architectures that Fedora does. You'll need to add "ExclusiveArch: %{fpc_arches}" to the spec. > %install > make DESTDIR=%{buildroot}/ LibDir=/lib64 ExecDir=/libexec install You should use "/%{_lib}" here instead of hard-coding "/lib64". > %{_libdir}/* > %{_libexecdir}/* Globbing like this is discouraged. Please use "%{_libdir}/%{name}/" and "%{_libexecdir}/%{name}/" here. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists > %{_datadir}/metainfo/ > %{_datadir}/applications/ This will mark your package as the owner of these directories. Please list the actual files here. Regarding the -data split: > Requires: %{name}-data This should be a versioned dependency: "%{name}-data = %{version}-%{release}" > License: GPL-2.0-or-later AND CC-BY-3.0 > [...] > %files > # GPL-2.0-or-later > [...] > %files data > # CC-BY-3.0 You can actually specify a different License tag for the subpackage. > %files > %{_datadir}/%{name}/AI/ > [...] > %files data > %dir %{_datadir}/%{name} > %{_datadir}/%{name}/*.txt > %{_datadir}/%{name}/Graphics/ > %{_datadir}/%{name}/Help/ > %{_datadir}/%{name}/Localization/ > %{_datadir}/%{name}/Maps/ > %{_datadir}/%{name}/Sounds/ > %{_datadir}/%{name}/Tribes/ This is fine, but a simpler approach would be to make -data own "%{_datadir}/%{name}" and then add "%exclude %{_datadir}/%{name}/AI". > %{_datadir}/icons/* Once again, your package will end up owning the directory. Since you have a requires on hicolor-icon-theme, you can use "%{_datadir}/icons/hicolor/*/apps/%{name}.svg" here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2445610 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445610%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
