https://bugzilla.redhat.com/show_bug.cgi?id=2428704
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #29 from Fabio Valentini <[email protected]> --- Thanks, did another full review pass over the spec file, and I think everything looks as good as it can now. As mentioned on Matrix, changing "BR: clang-devel" to "BR: clang" for the vendored libsqlite3-sys does not look correct. If the clang dependency is there because of bindgen usage, then it can just be "clang-libs". The lint from fedora-review about missing gcc/gcc-c++/clang is for C/C++ packages, which this one isn't - I suppose the lint got triggered by the presence of some .c or .h files in vendor/. Also, to make the conflict with the "golang-github-pressly-goose" package explicit, please add "Conflicts: golang-github-pressly-goose" to the spec file. As far as I can tell, all issues from the last review pass were addressed, and I see no new issues in the latest version. I'm not posting the full output / review checklist template of fedora-review here, since basically all ground has already been covered in the comments above. As far as I can tell, package is now compliant with generic and Rust-specific Packaging Guidelines, so the package is **APPROVED**, but please address the two minor things above before building the package. I hope that the feature that pulls in deno / swc can be made optional upstream soon, otherwise you're going to be stuck at 1.23.2 for a while :( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2428704 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202428704%23c29 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
