https://bugzilla.redhat.com/show_bug.cgi?id=2443679
--- Comment #8 from Fabio Valentini <[email protected]> --- Package looks mostly OK (built ok using the RPMs from the fearless_simd review), with two caveats (one bigger, one smaller): - Looks like the package doesn't actually contain license texts for MIT and Apache-2.0. It appears that I completely missed this when I filed the issue about excluding the unused stuff ( :( ), and rust2rpm also doesn't error out because the crate *does* contain at least one license file -- it just doesn't include all *three* of them. You can include the LICENSE-APACHE and LICENSE-MIT files from here for now, and file a PR / issue to get them included in published crates for later: https://github.com/LaurenzV/hayro/raw/refs/tags/hayro-jpeg2000-v0.3.3/LICENSE-APACHE https://github.com/LaurenzV/hayro/raw/refs/tags/hayro-jpeg2000-v0.3.3/LICENSE-MIT - The crate license is correctly patched, but the spec file is missing a comment for *why* this happens. Since CC0-1.0 is actually forbidden for code now, documenting that CC0-1.0 only applies to *content* under assets/ would be good. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2443679 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202443679%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
