https://bugzilla.redhat.com/show_bug.cgi?id=2445610
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Artur Frenszek-Iwicki <[email protected]> --- > URL: https://git.code.sf.net/p/c-evo-eh/code My impression is that it's expected the URL field leads to a human-readable website. I'd link to "https://sourceforge.net/projects/c-evo-eh/"; instead. > Group: Amusements/Games Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > BuildRequires: lazarus This will drag whole graphical IDE into the build. You can require "lazarus-tools" and "lazarus-lcl-gtk2" instead. > Requires: gtk2 > Requires: gdk-pixbuf2 > Requires: glibc > Requires: pango > Requires: at-spi2-core > Requires: cairo These are probably not needed, RPM should figure out the dependencies based on the libraries the program is linking to. > # If needed, its easier to debug Lazarus programs with an unstripped > executables > %global debug_package %{nil} Please don't. We want debuginfo in Fedora. > # Automatic strip not working! ( W: unstripped-binary-or-object ) > strip --strip-unneeded %{buildroot}%{_libexecdir}/%{name}/c-evo* > strip --strip-unneeded %{buildroot}%{_libdir}/%{name}/lib*.so Automated strip does not work because the bit above disables it. > %global _unpackaged_files_terminate_build 0 Discouraged, as it will allow new files to slip in unnoticed when updating versions. > %setup -c -q %{name}-%{version} > cd %{name}-%{version} Uhh, why, though? You're creating a directory called "%{name}-%{version}", only to unpack the source archive - which contains a directory with the same name - and then cd into it. You can probably just use "%autosetup" here (without any extra arguments). > %files > %{_datadir}/metainfo/* You should build-require "libappstream-glib" and run "appstream-util validate-relax --nonet" on AppData files. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage > %files > %{_datadir}/%{name} > %{_datadir}/icons/* You may want to move these to a -data subpackage and make it noarch. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2445610 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445610%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
