https://bugzilla.redhat.com/show_bug.cgi?id=1926523



--- Comment #6 from Matthieu Saulnier <[email protected]> ---
(In reply to Robert-André Mauchin 🐧 from comment #5)
>  - Bump to 0.12
Done

>  - Requires are autodetected.
Even for runtime dependancies ? Last time I built the package, the dep was
missing in the subpackage. Please check %%changelog entry.

>  - Shorten the Summary
Done

>  - Generate the docs with Sphinx
The documentation provided by upstream is *empty*. Have a look inside :)

>  - The tests are not run:
> 
> Ran 0 tests in 0.000s
> 
>  They should be run with Pytest.
Indeed. I tried to run tests with pytest, then I saw they require
python-omemo-backend-signal. But python-omemo-backend-signal requires
python-omemo itself. So I didn't wanted to create a cyclic dependancy and I
decided to disable the tests suite. Will take a look with upstream later...

>  - License is GPLv3+ not MIT
Indeed in the 0.11.0 release. In the 0.12.0 release, upstream has changed
license to MIT. So this issue is fixed by upgrading to latest release.

I made new release:

New Spec URL: https://fantom.fedorapeople.org/python-omemo.spec
New SRPM URL:
https://fantom.fedorapeople.org/python-omemo-0.12.0~beta-1.fc33.src.rpm

New copr build:
rawhide/f33:
https://copr.fedorainfracloud.org/coprs/fantom/poezio-omemo/build/2106926/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to